Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pins cron #1811

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix: pins cron #1811

merged 1 commit into from
Apr 12, 2022

Conversation

alanshaw
Copy link
Contributor

node-fetch does not support getReader (or at least the version we were using does not):

 TypeError: stream.getReader is not a function
    at ndjsonParse (file:///home/runner/work/nft.storage/nft.storage/node_modules/@nftstorage/ipfs-cluster/src/index.js:627:25)
    at ndjsonParse.next (<anonymous>)
    at streamRequest (file:///home/runner/work/nft.storage/nft.storage/node_modules/@nftstorage/ipfs-cluster/src/index.js:332:10)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async statusAll (file:///home/runner/work/nft.storage/nft.storage/node_modules/@nftstorage/ipfs-cluster/src/index.js:202:20)
    at async file:///home/runner/work/nft.storage/nft.storage/packages/cron/src/jobs/pins.js:185:24
    at async mapAndQueue (file:///home/runner/work/nft.storage/nft.storage/node_modules/streaming-iterables/dist/index.mjs:836:27)

@alanshaw alanshaw requested a review from vasco-santos April 12, 2022 11:58
vasco-santos
vasco-santos approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6b38b8
Status: ✅  Deploy successful!
Preview URL: https://1a584672.nft-storage-1at.pages.dev

View logs

@alanshaw alanshaw merged commit f112573 into main Apr 12, 2022
@alanshaw alanshaw deleted the fix/pins-cron2 branch April 12, 2022 12:02
@github-actions github-actions bot mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @vasco-santos